Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests with modulesync 7.3.0; allow latest dependency versions #414

Conversation

h-haaks
Copy link
Contributor

@h-haaks h-haaks commented Jan 17, 2024

Pull Request (PR) description

Resolving spec and acceptance issues

This Pull Request (PR) fixes the following issues

Fixes #394

end
end

require 'support/acceptance/constants.rb'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the constants where used in both spec and acceptance, so I separated them into to files.

IFS='-' read -ra values <<< "$java_raw_version"
java_version=${values[0]}
# early access format e.g 11-ea or 11.0.18-ea
IFS='-' read -ra java_raw_version <<< "$java_raw_version"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The java-11-openjdk-headless package in centos-stream8 ( used in acceptance tests ) report java version 11.0.18-ea.
These changes are needed for the script to resolv the major version correctly.
This issue and solution has been posted to atlassian support as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

require => Postgresql::Server::Db['jira'],
java_package => $java_package,
javahome => $java_home,
script_check_java_manage => true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need this to be able to run without error on centos-stream8

@h-haaks
Copy link
Contributor Author

h-haaks commented Jan 21, 2024

Could anyone please help me look at the failing acceptance tests here?

both CentOS 7 and Ubuntu 20.04 acceptance tests run fine locally.

For me both OracleLinux 7 and 8 fail locally with
Error: /Stage[main]/Postgresql::Server::Reload/Postgresql::Server::Instance::Reload[main]/Exec[postgresql_reload_main]: Failed to call refresh: invalid byte sequence in US-ASCII

@h-haaks h-haaks force-pushed the fix-teste-with-modulesync-7.2.0 branch 3 times, most recently from 7a8ed1c to 87d8dad Compare February 5, 2024 10:00
@h-haaks h-haaks force-pushed the fix-teste-with-modulesync-7.2.0 branch from 87d8dad to 1b218a9 Compare February 6, 2024 17:27
@h-haaks h-haaks force-pushed the fix-teste-with-modulesync-7.2.0 branch 4 times, most recently from 624ca46 to 632e297 Compare February 7, 2024 09:46
@h-haaks
Copy link
Contributor Author

h-haaks commented Feb 7, 2024

I have been hacking the acceptance test in this PR to figure out why mysql won't start on ubuntu 20.04 ...
I finally think I found the issue by printing the journal.
https://github.com/voxpupuli/puppet-jira/actions/runs/7812854040/job/21311068344#step:6:1347

Does anyone know how to fix apparmor issues here?

@h-haaks h-haaks force-pushed the fix-teste-with-modulesync-7.2.0 branch 8 times, most recently from 63576b8 to 04fdfec Compare February 12, 2024 07:27
@h-haaks h-haaks force-pushed the fix-teste-with-modulesync-7.2.0 branch from 04fdfec to 6ec9337 Compare February 12, 2024 07:34
@h-haaks h-haaks changed the title Fix tests with modulesync 7.2.0 Fix tests with modulesync 7.3.0 Feb 12, 2024
@bastelfreak bastelfreak changed the title Fix tests with modulesync 7.3.0 Fix tests with modulesync 7.3.0; allow latest dependency versions Feb 12, 2024
@bastelfreak bastelfreak added the enhancement New feature or request label Feb 12, 2024
@bastelfreak bastelfreak merged commit d367f39 into voxpupuli:master Feb 12, 2024
9 checks passed
@h-haaks h-haaks deleted the fix-teste-with-modulesync-7.2.0 branch February 12, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants