-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests with modulesync 7.3.0; allow latest dependency versions #414
Fix tests with modulesync 7.3.0; allow latest dependency versions #414
Conversation
CI complained about REFERENCE.md being outdated Auto-generated with `bundle exec rake release:prepare`
end | ||
end | ||
|
||
require 'support/acceptance/constants.rb' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the constants where used in both spec and acceptance, so I separated them into to files.
IFS='-' read -ra values <<< "$java_raw_version" | ||
java_version=${values[0]} | ||
# early access format e.g 11-ea or 11.0.18-ea | ||
IFS='-' read -ra java_raw_version <<< "$java_raw_version" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The java-11-openjdk-headless package in centos-stream8 ( used in acceptance tests ) report java version 11.0.18-ea.
These changes are needed for the script to resolv the major version correctly.
This issue and solution has been posted to atlassian support as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
require => Postgresql::Server::Db['jira'], | ||
java_package => $java_package, | ||
javahome => $java_home, | ||
script_check_java_manage => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need this to be able to run without error on centos-stream8
Could anyone please help me look at the failing acceptance tests here? both CentOS 7 and Ubuntu 20.04 acceptance tests run fine locally. For me both OracleLinux 7 and 8 fail locally with |
7a8ed1c
to
87d8dad
Compare
87d8dad
to
1b218a9
Compare
624ca46
to
632e297
Compare
I have been hacking the acceptance test in this PR to figure out why mysql won't start on ubuntu 20.04 ... Does anyone know how to fix apparmor issues here? |
63576b8
to
04fdfec
Compare
04fdfec
to
6ec9337
Compare
Pull Request (PR) description
Resolving spec and acceptance issues
This Pull Request (PR) fixes the following issues
Fixes #394